nginx/csp/frontend: allow Google Translate images #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
changed the title
This commit: * makes the frontend policy consistent with other policies which allow for Google Translate images * provides a template for addition of other browser-plugin-related policy * removes enforcement of policy order, although the served policies maintain their current ordering Closes getodk#1518 use more specific naming and avoid commentary
alxndrsn
force-pushed
the
frontend-csp-include-google-translate-images
branch
from
7d4f7f0 to
8092ac4
Compare
alxndrsn
changed the title
matthew-white
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
Closes #1518
What has been done to verify that this works as intended?
Existing tests, with a slight updated to ordering expectations.
Why is this the best possible solution? Were any other approaches considered?
Alternative: just hard-code the expected image. But in that case, it's fairly likely the issue will recur.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No effect.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)