nginx: update CSP for frontend maps #1468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
changed the title
matthew-white
requested review from
brontolosone
and removed request for
matthew-white
matthew-white
approved these changes
Nov 17, 2025
Member
matthew-white
left a comment
matthew-white
left a comment
There was a problem hiding this comment.
This one is a small change, so I think I can go ahead and approve. 👍
alxndrsn
pushed a commit
to alxndrsn/odk-central
that referenced
this pull request
Dec 4, 2025
Split from https://github.com/getodk/central/pull/1526/files#r2587794987 The only identifiable Worker in frontend is from OpenLayers for displaying maps, and requires blob:, not data:. Incorrect map-specific CSP introduced in getodk#1468.
2 tasks
alxndrsn
pushed a commit
to alxndrsn/odk-central
that referenced
this pull request
Dec 4, 2025
Split from https://github.com/getodk/central/pull/1526/files#r2587794987 The only identifiable Worker in frontend is from OpenLayers for displaying maps, and requires blob:, not data:. Incorrect map-specific CSP introduced in getodk#1468.
alxndrsn
added a commit
that referenced
this pull request
Dec 4, 2025
Split from https://github.com/getodk/central/pull/1526/files#r2587794987 The only identifiable Worker in frontend is from OpenLayers for displaying maps, and requires blob:, not data:. Incorrect map-specific CSP introduced in #1468. Co-authored-by: Hélène Martin <[email protected]> Co-authored-by: alxndrsn <alxndrsn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1403
What has been done to verify that this works as intended?
Fresh tests.
Why is this the best possible solution? Were any other approaches considered?
Simple. Open to alternatives, but couldn't think of any!
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
script-src, in which case'self'will need to be added. This will be noticed in testing, or in prod (where it would replace the current CSP violation with a new one, so not a big deal)Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)