-
Notifications
You must be signed in to change notification settings - Fork 209
csp-report: ensure Sentry requests are made with SNI #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
commented
Oct 16, 2025
alxndrsn
commented
Oct 16, 2025
alxndrsn
commented
Oct 21, 2025
alxndrsn
commented
Oct 21, 2025
alxndrsn
commented
Oct 21, 2025
Member
|
I filed the original issue, and I'm excited to see this PR to close it out. ✨ That said, I'm heads-down on #1152 at the moment, so I think it'd work best for someone else to review. Say @brontolosone or @sadiqkhoja? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1406
What has been done to verify that this works as intended?
Added new tests.
Why is this the best possible solution? Were any other approaches considered?
Nginx config change seems reasonable and minimal. Tests were required to understand the minimum nginx config required.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should remove browser console errors relating to CSP report.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)