Skip to content

Conversation

@alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Oct 16, 2025

Closes #1406

What has been done to verify that this works as intended?

Added new tests.

Why is this the best possible solution? Were any other approaches considered?

Nginx config change seems reasonable and minimal. Tests were required to understand the minimum nginx config required.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Should remove browser console errors relating to CSP report.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@alxndrsn alxndrsn marked this pull request as draft October 16, 2025 13:03
@alxndrsn alxndrsn marked this pull request as ready for review October 21, 2025 08:00
@matthew-white
Copy link
Member

I filed the original issue, and I'm excited to see this PR to close it out. ✨ That said, I'm heads-down on #1152 at the moment, so I think it'd work best for someone else to review. Say @brontolosone or @sadiqkhoja?

@matthew-white matthew-white removed their request for review October 21, 2025 16:52
@alxndrsn alxndrsn changed the title csp-report: fix Sentry HTTP host csp-report: ensure Sentry requests are made with SNI Nov 26, 2025
@alxndrsn alxndrsn merged commit 5c129e5 into getodk:next Nov 26, 2025
5 checks passed
@alxndrsn alxndrsn deleted the csp-report-test branch November 26, 2025 15:33
@matthew-white matthew-white linked an issue Dec 1, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/csp-report returns 502

2 participants