Merged
Conversation
Contributor
Author
|
this includes #70, I can rebase when that gets merged. |
meskio
reviewed
Nov 8, 2018
systray_windows.go
Outdated
Contributor
There was a problem hiding this comment.
I guess the compiler will produce the same code, but AFAIK the go style is to assign it in the append:
t.visibleItems = append(t.visibleItems[:i], t.visibleItems[i+1:]...)
kalikaneko
force-pushed
the
bug/keep-track-of-hidden-items-win
branch
from
1c715a8 to
b8beec1
Compare
in windows, Hide() destroys a menuItem. this has problems when later we try to Show() it and end up using the original menuID, for instance if we did hide several elements in a row: if we insert the element in the original position, it will end up inserted past some other elements that were intended to be placed after the items that were hidden. by keeping a slice where we insert and delete the id of the elements that are shown, we can sort this slice and take the index of a given element as the correct index in which we want to insert the menuItem when calling Show() again. - Resolves: getlantern#72
kalikaneko
force-pushed
the
bug/keep-track-of-hidden-items-win
branch
from
b8beec1 to
f5df9ef
Compare
ropog3ovomou
pushed a commit
to ropog3ovomou/systray
that referenced
this pull request
Jul 13, 2022
…dden-items-win keep track of hidden items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses bug described in #72