Revert "Use templated icons for the menu bar in macOS"#51
Merged
joesis merged 1 commit intogetlantern:masterfrom Jul 9, 2018
Merged
Revert "Use templated icons for the menu bar in macOS"#51joesis merged 1 commit intogetlantern:masterfrom
joesis merged 1 commit intogetlantern:masterfrom
Conversation
ropog3ovomou
pushed a commit
to ropog3ovomou/systray
that referenced
this pull request
Jul 13, 2022
…-icon Revert "Use templated icons for the menu bar in macOS"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies, this reverts #46 because of comments in #45 about breaking existing macos tray icons that depend on color.
A better approach would be to extend the API with an additional method SetTemplateIcon instead of changing setIcon.