Fix hiding/showing items with submenus on Windows#204
Merged
Crosse merged 1 commit intogetlantern:masterfrom Feb 22, 2022
Merged
Fix hiding/showing items with submenus on Windows#204Crosse merged 1 commit intogetlantern:masterfrom
Crosse merged 1 commit intogetlantern:masterfrom
Conversation
Contributor
|
Thanks @simonlindholm just wanted to acknowledge these and to thank you and to let you know we'll get to them! |
Contributor
|
@en0ma I wonder if you could possibly take a look at these PRs? |
|
+1 - The existing behavior also produces a panic if you call Hide() on the parent menu then call Hide() on the sub menu later. (That's what brought me here.) |
Crosse
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling Hide() on a menu item with a submenu would call DeleteMenu, which deletes both the item and the submenu. The submenu would then get lost when calling Show() again.
Switch to RemoveMenu, which only deletes the item, preserving the menu for Show() to resurrect.
(This already works as expected on Linux, haven't been able to test macOS.)