Add checkbox support for Linux#181
Merged
joesis merged 2 commits intogetlantern:masterfrom Nov 18, 2020
Merged
Conversation
fbrinker
changed the title
fbrinker
force-pushed
the
add-linux-checkboxes
branch
from
d4526bf to
a39295e
Compare
fbrinker
force-pushed
the
add-linux-checkboxes
branch
from
a39295e to
48b2241
Compare
Author
|
I've had to add a small fix to block Uncheck/Check triggering an endless loop, when called from another menu item |
ropog3ovomou
pushed a commit
to ropog3ovomou/systray
that referenced
this pull request
Jul 13, 2022
Add checkbox support for Linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #180
I had to implement a new method to decide if we want a checkbox or a normal menu item in Linux. Otherwise, all items would have ugly checkboxes.
To avoid introducing a breaking change, I've decided to add a new method. OSX and Windows users can use the new method too, for a cleaner interface, but without any difference. In a new major version, we could make only checkbox menu items (un)checkable. But that would be a breaking change of course. :)
What do you think?