Skip to content

Fix bug on darwin of setting icon for menu #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joesis merged 1 commit into from
Jun 2, 2020
Merged

Fix bug on darwin of setting icon for menu #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions systray_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func SetTemplateIcon(templateIconBytes []byte, regularIconBytes []byte) {
// SetIcon sets the icon of a menu item. Only works on macOS and Windows.
// iconBytes should be the content of .ico/.jpg/.png
func (item *MenuItem) SetIcon(iconBytes []byte) {
SetTemplateIcon(iconBytes, iconBytes)
item.SetTemplateIcon(iconBytes, iconBytes)
}

// SetTemplateIcon sets the icon of a menu item as a template icon (on macOS). On Windows, it
Expand All @@ -34,4 +34,4 @@ func (item *MenuItem) SetIcon(iconBytes []byte) {
func (item *MenuItem) SetTemplateIcon(templateIconBytes []byte, regularIconBytes []byte) {
cstr := (*C.char)(unsafe.Pointer(&templateIconBytes[0]))
C.setMenuItemIcon(cstr, (C.int)(len(templateIconBytes)), C.int(item.id), true)
}
}