Systray icon could not be changed dynamically#110
Merged
joesis merged 2 commits intogetlantern:masterfrom Dec 6, 2019
Merged
Conversation
|
Noticed this when upgrading a few days ago, went back to the commit before the walk rewrite. Thank you! |
Contributor
|
Thanks @ksubileau ! |
ropog3ovomou
pushed a commit
to ropog3ovomou/systray
that referenced
this pull request
Jul 13, 2022
Systray icon could not be changed dynamically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with the SetIcon method that make impossible to change the systray icon.
This is because when you call the SetIcon method with a different byte array, the icon will get written to a file with a constant name (systray.ico).
Then the icon is retrieved from the walk's ResourceManager, but this manager cache the icon according its name (see https://github.com/lxn/walk/blob/master/resourcemanager.go#L88). So the written file will not be read on the second call of SetIcon.
The proposed fix consist to compute the MD5 hash of the icon's byte array and use this hash to uniquely name the temporary icon file. Also the file will not be written if the icon was already loaded in memory.