Rename 'cfg_match' to 'match_cfg' to avoid collision of std nightly macro with the same name. #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
danielhenrymantilla
left a comment
danielhenrymantilla
left a comment
There was a problem hiding this comment.
Thanks for the swift PR! I have a naming nit but other than that it LGTM ✅
…acro with the same name. Fixes getditto#191.
Contributor
Author
|
Thanks for the speedy review! Updated to |
jsantell
changed the title
This was referenced Oct 19, 2023
danielhenrymantilla
approved these changes
Oct 23, 2023
Contributor
Author
|
Thank you! |
Collaborator
|
Released in |
danielhenrymantilla
added a commit
to danielhenrymantilla/maybe-dangling.rs
that referenced
this pull request
Nov 29, 2023
…in nightly std (#9) Fixes #8 Inspired by getditto/safer_ffi#191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190.