Skip to content

Conversation

@caitlinelfring
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features) see docs/README.md

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix for failing benchmark CI test on forks

What is the current behavior? (You can also link to an open issue here)
In #118, I wanted to automatically run and compare benchmark tests and comment on the PR with the results. Unfortunately, the github action that does the commenting doesn't work when the PR is opened from a fork.

What is the new behavior (if this is a feature change)?
No PR comments for now, until I can investigate further. Benchmarks will still run on CI

Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No

Other information:

@caitlinelfring caitlinelfring merged commit 161a9d9 into main Sep 28, 2021
@caitlinelfring caitlinelfring deleted the disable-benchmark-pr-comment branch September 28, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants