dev-util/mx: new package, add 9999#359
Conversation
Signed-off-by: Emmanuel Colin <[email protected]>
|
Thank you for the PR. Having live-ebuilds only is discouraged. Given that upstream tags versions, you can grab the tar.gz for the latest version instead. |
…3.2, add 7.60.1 Signed-off-by: Emmanuel Colin <[email protected]>
|
Thanks for your feedback ! |
|
Awesome! It looks much more clean now. |
dev-util/mx/mx-6.53.2.ebuild
Outdated
| SITE_PKG="$(python_get_sitedir)/${PN}" | ||
| python_moduleinto ${SITE_PKG} | ||
| python_domodule * | ||
| chmod 0755 "${D}/${SITE_PKG}/mx" || die "Failed to chmod mx executable" |
There was a problem hiding this comment.
The upstream code isn't well set up for "proper" installation, but it's absolutely not sensible to install the entire git repository into sitedir/mx/.
This also then results in sitedir/mx/mx being a bash script that tries to run sitedir/mx/mx.py using several different versions of python, but doesn't respect Gentoo's EPYTHON which means that PYTHON_DEPS` is accomplishing nothing. :(
I would recommend instead installing src/mx as a module, and writing your own simple python script to install to /usr/bin that simply imports the module directly.
Please also figure out which data files actually need to be installed. It may make sense to install them to /usr/share/mx and patch the application itself to find the resources there instead of relative to __file__.
There was a problem hiding this comment.
Took me quite some time to figure out this mess (the way modules were done prior version 7 were really messed up and version 7 also had to deal with backwards compatibility) but now it should be all good.
Signed-off-by: Emmanuel Colin <[email protected]>
Signed-off-by: Emmanuel Colin <[email protected]>
Signed-off-by: Emmanuel Colin <[email protected]>
Signed-off-by: Emmanuel Colin <[email protected]>
Signed-off-by: Emmanuel Colin <[email protected]>
|
Any review for this PR would be appreciated. Working on GraalVM's ebuild, I need some advice concerning dependency management. GraalVM's components require a lot of dependencies, listed in a
Having to deal with a custom build tool with its own dependency management for my first time ever writing an ebuild is difficult, so any help would be appreciated ! |
|
I think it would be best to use system-wise dependencies, in general. For the cases you would need to bring back old version then it can be better to download those. |
Add support for the mx compiler tool used by GraalVM. I plan to create the ebuild for GraalVM as well, so this PR is the first step.
This is my first ebuild, I would appreciate if you could give me some advice and tips !