Skip to content

feat(py): Add DAP helpers to registry#5073

Open
huangjeff5 wants to merge 6 commits intomainfrom
jh-dap-pr1
Open

feat(py): Add DAP helpers to registry#5073
huangjeff5 wants to merge 6 commits intomainfrom
jh-dap-pr1

Conversation

@huangjeff5
Copy link
Copy Markdown
Contributor

  • Wires Dynamic Action Provider (DAP) into Registry.resolve_action: define_dynamic_action_provider now attaches the DynamicActionProvider to the registered DAP Action, and resolution uses get_action(kind, name). Hand-registered providers that still resolve via run({kind, name}) → Action keep working.
  • Adds parse_dap_qualified_name and resolve_action_by_key support for /dynamic-action-provider/:/.

This is to support DAP overall. Next PR: Extends the generate path and options typing (tools: list[str | Tool], etc.) using the updated resolve_action / resolve_tool calls from this PR.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for nested actions exposed by Dynamic Action Providers (DAPs). Key changes include the addition of a utility to parse DAP-qualified names in the format provider:innerKind/innerName, updates to the registry's action resolution logic to handle these qualified keys, and the attachment of DAP instances to actions for easier retrieval. The implementation maintains backward compatibility with the legacy action resolution protocol and includes comprehensive tests for the new functionality. I have no feedback to provide.

@huangjeff5 huangjeff5 marked this pull request as ready for review April 8, 2026 16:19
@huangjeff5 huangjeff5 requested a review from pavelgj April 8, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant