Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for nested actions exposed by Dynamic Action Providers (DAPs). Key changes include the addition of a utility to parse DAP-qualified names in the format provider:innerKind/innerName, updates to the registry's action resolution logic to handle these qualified keys, and the attachment of DAP instances to actions for easier retrieval. The implementation maintains backward compatibility with the legacy action resolution protocol and includes comprehensive tests for the new functionality. I have no feedback to provide.
huangjeff5
commented
Apr 8, 2026
huangjeff5
commented
Apr 8, 2026
huangjeff5
commented
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to support DAP overall. Next PR: Extends the generate path and options typing (tools: list[str | Tool], etc.) using the updated resolve_action / resolve_tool calls from this PR.