Map Shift+Enter to newline #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: notkainoa <[email protected]>
…nstant Co-authored-by: notkainoa <[email protected]>
Co-authored-by: notkainoa <[email protected]>
Co-authored-by: notkainoa <[email protected]>
- Add !this.disposed check before ptyInput to prevent race condition - Add comprehensive test coverage for keyboard mapping logic - Tests verify Shift+Enter mapping and edge cases with modifiers Co-authored-by: notkainoa <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
- Add isNewlineInsert parameter to skip injection/telemetry on newline insert - Rename test file to match module (terminalKeybindings.test.ts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapped Shift+Enter to Ctrl+J in CLI agent terminals so Shift+Enter inserts a new line. Applies only to agent terminal view.
Fixes #636.
Rebased from #657 (original work by @notkainoa).
Files Changed
src/renderer/terminal/terminalKeybindings.ts(new)src/renderer/terminal/TerminalSessionManager.tssrc/renderer/terminal/SessionRegistry.tssrc/renderer/components/TerminalPane.tsxsrc/renderer/components/ChatInterface.tsxsrc/renderer/components/MultiAgentTask.tsxsrc/test/renderer/TerminalSessionManager.test.ts(new)Feature
CTRL_J_ASCIIandshouldMapShiftEnterToCtrlJ()interminalKeybindings.tsTerminalSessionManagerwhenmapShiftEnterToCtrlJis setNote
Medium Risk
Medium risk because it changes terminal keyboard event handling and refactors PTY input/injection logic; regressions could affect command submission, telemetry, or initial prompt injection behavior.
Overview
Enables Shift+Enter to insert a newline in agent-backed terminal panes by optionally mapping Shift+Enter to Ctrl+J (LF) via an xterm custom key handler.
Threads a new
mapShiftEnterToCtrlJflag fromChatInterface/MultiAgentTaskthroughTerminalPaneandSessionRegistryintoTerminalSessionManager, and refactors terminal input handling intohandleTerminalInput()so newline-insert events bypass enter-press telemetry and pending-injection submission logic.Adds
terminalKeybindings.tsplus a small Vitest suite to validate the keybinding predicate and Ctrl+J encoding.Written by Cursor Bugbot for commit 347f8fd. This will update automatically on new commits. Configure here.