fix: native module architecture mismatch in x64 builds#709
Merged
rabanspiegel merged 2 commits intomainfrom Feb 2, 2026
Merged
fix: native module architecture mismatch in x64 builds#709rabanspiegel merged 2 commits intomainfrom
rabanspiegel merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
cschubiner
pushed a commit
to cschubiner/emdash
that referenced
this pull request
Feb 2, 2026
…#709) * fix: build each mac architecture separately to fix native module mismatch (generalaction#706) * fix: fail verification if no app bundles found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #706
The x64 mac build was getting arm64 native modules because we rebuilt all architectures first, then ran electron-builder with
--x64 --arm64. The last rebuild (arm64) overwrote the x64 modules, so both builds used arm64 natives.Now we build each architecture separately - rebuild native modules, then package, then move to the next arch.
Also added a CI step that verifies native module architectures match the Electron binary, so this can't regress.
Note
Medium Risk
Medium risk because it changes the macOS release workflow build order and adds new CI checks; misconfiguration could break or slow releases, but it’s isolated to CI packaging.
Overview
Fixes macOS x64/arm64 native module mismatches by building each architecture separately: for each selected arch, the workflow now runs
@electron/rebuildforsqlite3,node-pty, andkeytar, then packages viaelectron-builder(both unsigned and signed jobs).Adds a post-build verification step that inspects each generated
.appbundle and fails CI if the Electron binary orsqlite3native module architecture doesn’t match the expected arch, preventing regressions like #706.Written by Cursor Bugbot for commit 5ed47fa. This will update automatically on new commits. Configure here.