-
Notifications
You must be signed in to change notification settings - Fork 76
Update to work with Rust 1.85 #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-string literals `c""` https://doc.rust-lang.org/edition-guide/rust-2021/c-string-literals.html : thread '<unnamed>' panicked at /Users/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.109/src/lit.rs:1020:13: Unrecognized literal: `c""`
…parse file: /Users/user/.cargo/git/checkouts/itertools-eb89fd56766bcf43/8761fbe/src/format.rs, Syn(Error("expected ','").
|
This PR keeps growing and growing as I fix more tests. I would love to hear suggestions for splitting it up. It would also be great if there was a way to get |
|
We're re-writing much of the core incl. to break the cargo-reliance so messy PR is ok for now to fix the techdebt np. Thanks so much for doing this 🚀 |
…e output of SafetyReport assert_eq failures comparable.
|
I updated the PR so the tests pass under latest stable Rust 1.85.0. It's ready for review. |
|
I used rustfmt to fix the formatting. |
|
Any news when it can land? |
|
Bump, +1, we really need c-literal support. |
needed update is landing so slowly there - geiger-rs/cargo-geiger#518
|
@pinkforest Would you be interested in reviewing this PR, or is there another person I can ask? |
needed update is landing so slowly there - geiger-rs/cargo-geiger#518
|
@pinkforest could you give any hints when new release will land with this fix? |
|
0.12 is out 🎉 thanks everyone |
This PR fixes
Changes:
synv1 to v2 to support new C-style string literals. This fixes the panic:Unrecognized literal: c"".kratesdepkratesand its dependenciesI apologize for the size of this PR. I'm happy to split it up however you wish - just let me know in the comments. If you want to review it as-is, it's probably good to review it one commit at a time.
Testing
The package tests pass on my laptop, with an M4 Pro and macOS 15.3.1, and Rust 1.85.0.
I also built the
cargo-geigerbinary and ran it locally on another project (https://github.com/mleonhard/jtoo-rs) and confirmed that it worked as expected.