Skip to content

Add chainFirstEitherK(W) in ReaderTaskEither module#1562

Merged
gcanti merged 1 commit into
2.12from
add-RTE-chainFirstEitherK
Nov 22, 2021
Merged

Add chainFirstEitherK(W) in ReaderTaskEither module#1562
gcanti merged 1 commit into
2.12from
add-RTE-chainFirstEitherK

Conversation

@DenisFrezzato
Copy link
Copy Markdown
Collaborator

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • Run npm install in the repository root.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (npm test).

Note. If you've fixed a bug please link the related issue or, if missing, open an issue before sending a PR.

Note. If you find a typo in the documentation, make sure to modify the corresponding source (docs are generated).

Note. If you want to send a PR related to fp-ts@1.x please create your branch from 1.x

@DenisFrezzato DenisFrezzato requested a review from gcanti August 20, 2021 06:14
@vinassefranche
Copy link
Copy Markdown
Contributor

@gcanti is there something blocking on this P.R. I need this too :-)

Comment thread src/ReaderTaskEither.ts
* @category combinators
* @since 2.12.0
*/
export const chainFirstEitherKW: <E2, A, B>(
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chainFirstEitherKW - chain - first - either - k - w, man this is crazy 😂

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There already are also chainFirstTaskEitherKW, chainFirstReaderEitherKW and chainFirstReaderTaskKW among others...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@DenisFrezzato DenisFrezzato force-pushed the add-RTE-chainFirstEitherK branch 2 times, most recently from fbb649d to 53929ce Compare October 31, 2021 10:59
@DenisFrezzato DenisFrezzato force-pushed the add-RTE-chainFirstEitherK branch from 53929ce to 45ed8a9 Compare October 31, 2021 10:59
@gcanti gcanti changed the base branch from master to 2.12 November 22, 2021 10:02
@gcanti gcanti merged commit 59fce5b into 2.12 Nov 22, 2021
@gcanti gcanti deleted the add-RTE-chainFirstEitherK branch November 22, 2021 10:07
@gcanti gcanti added this to the 2.12 milestone Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants