Skip to content

Conversation

@azeey
Copy link
Collaborator

@azeey azeey commented Mar 28, 2024

🦟 Bug fix

Summary

This fixes an error when building https://github.com/gazebo-release/sdformat_vendor/ in the ROS buildfarm where CMAKE_STAGING_PREFIX is used

Similar to gazebosim/gz-tools#137

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This fixes an error when building https://github.com/gazebo-release/sdformat_vendor/ in the ROS buildfarm where `CMAKE_STAGING_PREFIX` is used

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from scpeters as a code owner March 28, 2024 20:52
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 28, 2024
@codecov
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (ff9b3ad) to head (a038b59).
Report is 2 commits behind head on sdf14.

Additional details and impacted files
@@           Coverage Diff           @@
##            sdf14    #1387   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files         134      134           
  Lines       17751    17751           
=======================================
  Hits        16406    16406           
  Misses       1345     1345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brew CI failure looks unrelated, I believe caused by update to pybind11:

@azeey azeey merged commit afd56d2 into gazebosim:sdf14 Mar 28, 2024
@azeey azeey deleted the install_relative branch March 28, 2024 21:36
@scpeters
Copy link
Member

brew CI failure looks unrelated, I believe caused by update to pybind11:

fix in #1389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants