-
Notifications
You must be signed in to change notification settings - Fork 54
Add the action for PR Metadata validation #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changelog Validation Failed
The following issues were found with this PR:
-
❌ Missing changelog file
- Please add a changelog file to the
.changelog/directory - Name it descriptively (e.g.,
fix-bug-123.md,add-new-feature.md) - Document what changed, why, and any breaking changes
- Please add a changelog file to the
-
❌ Missing version bump trailer
- Please add a
Version-Bump:trailer to one of your commit messages usinggit commit --trailer 'Version-Bump: <type>' - Valid types:
patch(bug fixes),minor(new features),major(breaking changes) - Example:
Fix critical bug in user authentication This fixes an issue where users couldn't log in after password reset. Version-Bump: patch
- Please add a
Please fix the issues above and push your changes. The validation will run again automatically.
We probably want to add a |
Signed-off-by: Jose Luis Rivero <[email protected]> Version-Bump: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changelog Validation Failed
The following issues were found with this PR:
-
❌ Missing changelog file
- Please add a changelog file to the
.changelog/directory - Name it descriptively (e.g.,
fix-bug-123.md,add-new-feature.md) - Document what changed, why, and any breaking changes
- Please add a changelog file to the
-
❌ Missing version bump trailer
- Please add a
Version-Bump:trailer to one of your commit messages usinggit commit --trailer 'Version-Bump: <type>' - Valid types:
patch(bug fixes),minor(new features),major(breaking changes) - Example:
Fix critical bug in user authentication This fixes an issue where users couldn't log in after password reset. Version-Bump: patch
- Please add a
Please fix the issues above and push your changes. The validation will run again automatically.
Signed-off-by: Jose Luis Rivero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changelog Validation Failed
The following issues were found with this PR:
-
❌ Missing changelog file
- Please add a changelog file to the
.changelog/directory - Name it descriptively (e.g.,
fix-bug-123.md,add-new-feature.md) - Document what changed, why, and any breaking changes
- Please add a changelog file to the
-
✅ Version bump trailer found - Type:
none
Please fix the issues above and push your changes. The validation will run again automatically.
Nice this is working. I'm going to add a changelog file. |
Signed-off-by: Jose Luis Rivero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Changelog Validation Passed
All required data for the changelog validation checks have passed:
- ✅ Changelog file found - Changes are documented
- ✅ Version bump trailer found - Type:
none
This PR is ready for review! 🚀
Signed-off-by: Jose Luis Rivero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Changelog Validation Passed
All required data for the changelog validation checks have passed:
- ✅ Changelog file found - Changes are documented
- ✅ Version bump trailer found - Type:
none
This PR is ready for review! 🚀
|
Looks good, but we've agreed to wait to merge it till after the Jetty release. |
🎉 New feature
Related and a resurrection of gazebo-tooling/release-tools#246
Summary
An experimental first integration of the https://github.com/gazebo-tooling/pr-data-action/ into the main branch only of this repository. The github action added will check each of the PRs target to
mainfor the presence of a changelog entry inside the .changelog directory of the repository and a Git Trailer that tells if what kind of version bump be done for releasing a PR (mostly minor, patch).Test it
The github action feedback should appear in this PR and explain what is missing and how to do it. More information in the README of the github action repository.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.