Skip to content

Conversation

@j-rivero
Copy link
Contributor

🎉 New feature

Related and a resurrection of gazebo-tooling/release-tools#246

Summary

An experimental first integration of the https://github.com/gazebo-tooling/pr-data-action/ into the main branch only of this repository. The github action added will check each of the PRs target to main for the presence of a changelog entry inside the .changelog directory of the repository and a Git Trailer that tells if what kind of version bump be done for releasing a PR (mostly minor, patch).

Test it

The github action feedback should appear in this PR and explain what is missing and how to do it. More information in the README of the github action repository.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

@j-rivero j-rivero requested a review from caguero as a code owner July 21, 2025 14:51
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Jul 21, 2025
Signed-off-by: Jose Luis Rivero <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changelog Validation Failed

The following issues were found with this PR:

  • Missing changelog file

    • Please add a changelog file to the .changelog/ directory
    • Name it descriptively (e.g., fix-bug-123.md, add-new-feature.md)
    • Document what changed, why, and any breaking changes
  • Missing version bump trailer

    • Please add a Version-Bump: trailer to one of your commit messages using git commit --trailer 'Version-Bump: <type>'
    • Valid types: patch (bug fixes), minor (new features), major (breaking changes)
    • Example:
      Fix critical bug in user authentication
      
      This fixes an issue where users couldn't log in
      after password reset.
      
      Version-Bump: patch
      

Please fix the issues above and push your changes. The validation will run again automatically.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jul 21, 2025
@j-rivero
Copy link
Contributor Author

  • Please add a Version-Bump: trailer to one of your commit messages using git commit --trailer 'Version-Bump: <type>'

We probably want to add a None value to the accepted values of the Version-bump trailer to indicate that some PRs have nothing to do with versioning the code (like this one of some of them affecting other infra pieces).

@azeey azeey added this to the Jetty Release milestone Jul 28, 2025
Signed-off-by: Jose Luis Rivero <[email protected]>
Version-Bump: None
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changelog Validation Failed

The following issues were found with this PR:

  • Missing changelog file

    • Please add a changelog file to the .changelog/ directory
    • Name it descriptively (e.g., fix-bug-123.md, add-new-feature.md)
    • Document what changed, why, and any breaking changes
  • Missing version bump trailer

    • Please add a Version-Bump: trailer to one of your commit messages using git commit --trailer 'Version-Bump: <type>'
    • Valid types: patch (bug fixes), minor (new features), major (breaking changes)
    • Example:
      Fix critical bug in user authentication
      
      This fixes an issue where users couldn't log in
      after password reset.
      
      Version-Bump: patch
      

Please fix the issues above and push your changes. The validation will run again automatically.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changelog Validation Failed

The following issues were found with this PR:

  • Missing changelog file

    • Please add a changelog file to the .changelog/ directory
    • Name it descriptively (e.g., fix-bug-123.md, add-new-feature.md)
    • Document what changed, why, and any breaking changes
  • Version bump trailer found - Type: none

Please fix the issues above and push your changes. The validation will run again automatically.

@j-rivero
Copy link
Contributor Author

  • Version bump trailer found - Type: none

Nice this is working. I'm going to add a changelog file.

Signed-off-by: Jose Luis Rivero <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Changelog Validation Passed

All required data for the changelog validation checks have passed:

  • Changelog file found - Changes are documented
  • Version bump trailer found - Type: none

This PR is ready for review! 🚀

Signed-off-by: Jose Luis Rivero <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Changelog Validation Passed

All required data for the changelog validation checks have passed:

  • Changelog file found - Changes are documented
  • Version bump trailer found - Type: none

This PR is ready for review! 🚀

@j-rivero j-rivero marked this pull request as draft August 4, 2025 18:12
@azeey azeey removed this from the Jetty Release milestone Aug 4, 2025
@azeey
Copy link
Contributor

azeey commented Aug 4, 2025

Looks good, but we've agreed to wait to merge it till after the Jetty release.

@caguero caguero removed the 🪵 jetty Gazebo Jetty label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

4 participants