Skip to content

Support for none in version bumps #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

Support for none in version bumps #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions validate-pr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ NC='\033[0m' # No Color

# Configuration
CHANGELOG_DIR="${CHANGELOG_DIR:-.changelog}"
REQUIRED_VERSION_BUMPS=("patch" "minor" "major")
REQUIRED_VERSION_BUMPS=("patch" "minor" "major", "none")

# Helper functions
log_info() {
Expand Down Expand Up @@ -116,7 +116,7 @@ check_version_bump_trailer() {
# Look for Version-Bump: trailer (case insensitive)
if echo "${message}" | grep -qi "Version-Bump:"; then
# Extract the value after Version-Bump:
bump_value=$(echo "${message}" | grep -oiE "Version-Bump:\s*(patch|minor|major)" | cut -d':' -f2 | xargs | tr '[:upper:]' '[:lower:]')
bump_value=$(echo "${message}" | grep -oiE "Version-Bump:\s*(patch|minor|major|none)" | cut -d':' -f2 | xargs | tr '[:upper:]' '[:lower:]')

if [[ -n "${bump_value}" ]]; then
# Validate the bump value
Expand All @@ -140,6 +140,7 @@ check_version_bump_trailer() {
echo " - Version-Bump: patch (for bug fixes)"
echo " - Version-Bump: minor (for new features)"
echo " - Version-Bump: major (for breaking changes)"
echo " - Version-Bump: none (for changes not affecting the releasing code)"
echo " 2. The trailer should be on its own line at the end of the commit message"
echo ""
echo "Example commit message:"
Expand Down Expand Up @@ -244,7 +245,7 @@ The following issues were found with this PR:
if [[ "$version_bump_passed" != "true" ]]; then
comment_body+="- ❌ **Missing version bump trailer**
- Please add a \`Version-Bump:\` trailer to one of your commit messages using \`git commit --trailer 'Version-Bump: <type>'\`
- Valid types: \`patch\` (bug fixes), \`minor\` (new features), \`major\` (breaking changes)
- Valid types: \`patch\` (bug fixes), \`minor\` (new features), \`major\` (breaking changes) \`none\` (changes not affecting releases)
- Example:
\`\`\`
Fix critical bug in user authentication
Expand Down