Temp fix for scroll behavior problems #7758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
reviewed
Aug 30, 2018
packages/gatsby-link/src/index.js
Outdated
| } | ||
|
|
||
| // Temp hack while awaiting https://github.com/reach/router/issues/119 | ||
| window.__navigatingToLink = true |
Contributor
There was a problem hiding this comment.
I think this should be in
rather thanLink component to cover programmatic navigation
Contributor
There was a problem hiding this comment.
oh, and if it was moved there probably it should be in if (!option.replace) (not entirely sure here)
Contributor
Author
There was a problem hiding this comment.
oo right, programmatic nav, forgot about that. Will switch over.
Contributor
Author
There was a problem hiding this comment.
and yeah, replacing shouldn't update the scroll
pieh
reviewed
Aug 30, 2018
packages/gatsby-link/src/index.js
Outdated
| if (typeof window !== `undefined`) { | ||
| window.__navigatingToLink = false | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I would move this to
| location.action = `push` | ||
|
|
||
| // Temp hack while awaiting https://github.com/reach/router/issues/119 | ||
| if (window.__navigatingToLink) { |
Contributor
There was a problem hiding this comment.
Are we sure this will work everywhere?
Contributor
Author
There was a problem hiding this comment.
Any reason for suspecting it wouldn't?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7454