Skip to content

[gatsby-plugin-sharp] re: make width optional for fixed and fluid images #7520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[gatsby-plugin-sharp] re: make width optional for fixed and fluid images #7520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82fc912
Remove default values for width and maxWidth, correctly round when wi…
Aug 21, 2018
cbe1c0e
Merge branch 'master' into topics/optional-width-2
Aug 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/gatsby-plugin-sharp/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,14 @@ const processFile = (file, jobs, cb, reporter) => {
} else {
clonedPipeline = pipeline
}
// Sharp only allows ints as height/width. Since height isn't always
// set, check first before trying to round it.
let roundedHeight = args.height
if (roundedHeight) {
roundedHeight = Math.round(roundedHeight)
}
const roundedWidth = Math.round(args.width)
// Sharp only allows ints as height/width. Since either height or width
// could not be set, check first before trying to round them.
let roundedHeight = args.hasOwnProperty(args, `height`)
? Math.round(args.height)
: undefined
const roundedWidth = args.hasOwnProperty(args, `width`)
? Math.round(args.width)
: undefined
clonedPipeline
.resize(roundedWidth, roundedHeight)
.crop(args.cropFocus)
Expand Down
2 changes: 0 additions & 2 deletions packages/gatsby-transformer-sharp/src/extend-node-type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ const fixedNodeType = ({
args: {
width: {
type: GraphQLInt,
defaultValue: 400,
},
height: {
type: GraphQLInt,
Expand Down Expand Up @@ -222,7 +221,6 @@ const fluidNodeType = ({
args: {
maxWidth: {
type: GraphQLInt,
defaultValue: 800,
},
maxHeight: {
type: GraphQLInt,
Expand Down