Add warning for relative paths in source-filesystem. #6563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Deploy preview for using-postcss-sass failed. Built with commit 9afba60 https://app.netlify.com/sites/using-postcss-sass/deploys/5b51036fdd28ef732c118d2f |
Collaborator
|
Deploy preview for using-drupal ready! Built with commit 9afba60 |
Collaborator
|
Deploy preview for gatsbygram ready! Built with commit 9afba60 |
Contributor
|
Thanks for jumping on a fix! Yeah, this should just hard error since the plugin won't work otherwise and it's an easy fix for people. |
Contributor
|
Can we convert relative path to absolute path in plugin instead of forcing user to explicitely provide absolute path? |
Contributor
|
Haha great point @pieh yeah, we can safely assume the path is relative from the root of the site. |
Contributor
Author
|
That makes sense! This fixes #6367, tested on https://github.com/fabe/test-gatsby-json-image |
This was referenced Apr 7, 2022
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
* Add warning for relative paths in source-filesystem. * Fix path instead of warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a warning when using
gatsby-source-filesystemwith a relative path. Relative paths work, but fail silently when trying to query images (typeFile). Related issue: #6367I added this as a warning, should it
panicinstead?