Skip to content

Conversation

@shannonbux
Copy link
Contributor

In preparation for the docs sprint, thought this could use a lot of polish.

Questions I could use extra eyes on @jlengstorf @calcsam @m-allanson :

  • how to make this shorter! It's crazy long. And it'd be cool if it could be downloaded as a printable pdf or something
  • Wondering if our examples of good articles are good enough (under What are Guide Articles?)
  • Wondering if the ## Format of a doc ought to be pulled into a new standalone doc (and possibly have real content with commentary inline or something)
  • Are the rules about plagiarism reasonable (under ## search for content)?

shannonbux added 2 commits July 16, 2018 16:38
In preparation for the docs sprint, thought this could use a lot of polish.

Questions I could use extra eyes on @jlengstorf  @calcsam @m-allanson :
- how to make this shorter! It's crazy long. And it'd be cool if it could be downloaded as a printable pdf or something
- Wondering if our examples of good articles are good enough (under What are Guide Articles?)
- Wondering if the ## Format of a doc ought to be pulled into a new standalone doc (and possibly have real content with commentary inline or something)
- Are the rules about plagiarism reasonable (under ## search for content)?
@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit 50ec6dd

https://deploy-preview-6489--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit 50ec6dd

https://deploy-preview-6489--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 16, 2018

Deploy preview for using-drupal ready!

Built with commit 259363f

https://deploy-preview-6489--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 16, 2018

Deploy preview for gatsbygram ready!

Built with commit 259363f

https://deploy-preview-6489--gatsbygram.netlify.com


In tutorials that are meant for beginners, use as few hyperlinks as possible to minimize distractions. In docs, it's ok to include as many hyperlinks as necessary to provide relevant and interesting information and resources.

## Begin sentences clearly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "indicate optionality" as this is what we're doing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be honest: I have no idea what "indicate optionality" means.

Can we rephrase that to be friendlier to English as a second language/folks like me who don't read good? 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Clarify when a section is not required"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@calcsam

This comment has been minimized.

@jlengstorf

This comment has been minimized.

@shannonbux shannonbux requested a review from KyleAMathews July 17, 2018 17:38
@shannonbux
Copy link
Contributor Author

Will compare this to a list apart style guide per @jlengstorf 's recommendation

@KyleAMathews
Copy link
Contributor

Deploy preview for using-postcss-sass failed.

Built with commit 259363f

https://app.netlify.com/sites/using-postcss-sass/deploys/5b4e2b83c6aed645fe8fd9fb

@m-allanson
Copy link
Contributor

Huh I thought I commented on this yesterday but maybe I didn't hit submit.

Here's another technical writing style guide that could be a useful reference: https://www.digitalocean.com/community/tutorials/digitalocean-s-technical-writing-guidelines

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I left some comments - sorry for the noisy review, a lot of the comments are minor tweaks that I'd usually just do myself, but it's quite a long document so I just added everything as a comment.

- [What are Guide articles?](#what-are-guide-articles)
- [What can I write an article about?](#what-can-i-write-an-article-about)
- [How to contribute](#how-to-contribute)
- [How to contribute](#how-to-submit-a-pr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title and URL don't match here. Maybe they could be switched to [How to submit your article](#how-to-submit-your-article) or similar?

Before you begin writing, make sure to read the rest of this style guide.

# How to contribute
# How to submit a PR

This comment was marked as resolved.

find the article stub you'd like to write or edit. All stubs will be in an
index.md file.
find the article stub you'd like to write or edit. All stubs will end with the .md file ending since they are written in Markdown.
3. Click the "Edit this file" pencil icon and make your changes to the file in

This comment was marked as resolved.

find the article stub you'd like to write or edit. All stubs will end with the .md file ending since they are written in Markdown.
3. Click the "Edit this file" pencil icon and make your changes to the file in
GitHub-flavored Markdown.
4. Scroll to the bottom of the screen and add a commit message explaining your

This comment was marked as resolved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing opening " around pull request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean this? "Create a new branch for this commit and start a pull request"

# How to submit a PR

You can create a PR with your draft article (or edits on an existing article) in
two ways:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two sections could have headings? Something like Write your article on GitHub and Write your article locally


Each article should explain exactly one concept, and that concept should be
apparent from the article's title.
The introduction paragraph should be a 1-2 sentence explanation of the main

This comment was marked as resolved.

them to a GitHub repository of your own, then push them to GitHub. Then you can
right click the image and copy its image source.
Format language keywords as code - this is done with the backtick key (located
to the left of the "1" key on a US keyboard) in GitHub-flavored markdown. For

This comment was marked as resolved.

them to a GitHub repository of your own, then push them to GitHub. Then you can
right click the image and copy its image source.

Then you'd just need to reference them in your markdown file with this syntax:

This comment was marked as resolved.

Then you'd just need to reference them in your markdown file with this syntax:
`[your alt text](your url)`

Then the images should show up when you click the "preview table" tab.

This comment was marked as resolved.


Also, there's a community of support from a whole team of contributors, whom you
can bounce ideas off of and ask for input on your writing. Stay active in the
contributors chat room and ask lots of questions.

This comment was marked as resolved.

@m-allanson
Copy link
Contributor

@shannonbux in answer to your questions up there:

how to make this shorter! It's crazy long.

Both the List Apart and Digital Ocean styleguides are pretty long too. I don't think we should worry about shortening as long as the structure is good.

Wondering if our examples of good articles are good enough (under What are Guide Articles?)

Hmm those links didn't work for me - they all go to 'Page not found' page

Wondering if the ## Format of a doc ought to be pulled into a new standalone doc (and possibly have real content with commentary inline or something)

I don't understand this question... sorry!

Are the rules about plagiarism reasonable (under ## search for content)?

This section could be more explicit I guess? Something about how it's not OK to copy and paste large chunks of existing content unless you've checked with the author?

Need help formatting code examples within code examples

```
markdown stuff

```shell
code
``` <--how do I make sure this doesn't close out the first three backticks?

more markdown stuff
```
@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 21, 2018

Deploy preview for using-contentful failed.

Built with commit a0032b8

https://app.netlify.com/sites/using-contentful/deploys/5b80530982d3f15bfffd1a2e

@KyleAMathews
Copy link
Contributor

Deploy preview for image-processing failed.

Built with commit e2fac23

https://app.netlify.com/sites/image-processing/deploys/5b7c5ebcfdd72a0f17a0332f

@shannonbux
Copy link
Contributor Author

Would partially finish #4284, #6779, and #6778

@shannonbux shannonbux merged commit 5d5b3c2 into master Aug 31, 2018
@shannonbux shannonbux deleted the style-guide-revamp branch August 31, 2018 17:35
@shannonbux
Copy link
Contributor Author

Closes #823 and #4284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants