-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Polishing style guide #6489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polishing style guide #6489
Conversation
In preparation for the docs sprint, thought this could use a lot of polish. Questions I could use extra eyes on @jlengstorf @calcsam @m-allanson : - how to make this shorter! It's crazy long. And it'd be cool if it could be downloaded as a printable pdf or something - Wondering if our examples of good articles are good enough (under What are Guide Articles?) - Wondering if the ## Format of a doc ought to be pulled into a new standalone doc (and possibly have real content with commentary inline or something) - Are the rules about plagiarism reasonable (under ## search for content)?
|
Deploy preview for using-drupal ready! Built with commit 50ec6dd |
|
Deploy preview for gatsbygram ready! Built with commit 50ec6dd |
|
Deploy preview for using-drupal ready! Built with commit 259363f |
|
Deploy preview for gatsbygram ready! Built with commit 259363f |
docs/docs/gatsby-style-guide.md
Outdated
|
|
||
| In tutorials that are meant for beginners, use as few hyperlinks as possible to minimize distractions. In docs, it's ok to include as many hyperlinks as necessary to provide relevant and interesting information and resources. | ||
|
|
||
| ## Begin sentences clearly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps "indicate optionality" as this is what we're doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be honest: I have no idea what "indicate optionality" means.
Can we rephrase that to be friendlier to English as a second language/folks like me who don't read good? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Clarify when a section is not required"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Will compare this to a list apart style guide per @jlengstorf 's recommendation |
|
Deploy preview for using-postcss-sass failed. Built with commit 259363f https://app.netlify.com/sites/using-postcss-sass/deploys/5b4e2b83c6aed645fe8fd9fb |
|
Huh I thought I commented on this yesterday but maybe I didn't hit submit. Here's another technical writing style guide that could be a useful reference: https://www.digitalocean.com/community/tutorials/digitalocean-s-technical-writing-guidelines |
m-allanson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I left some comments - sorry for the noisy review, a lot of the comments are minor tweaks that I'd usually just do myself, but it's quite a long document so I just added everything as a comment.
docs/docs/gatsby-style-guide.md
Outdated
| - [What are Guide articles?](#what-are-guide-articles) | ||
| - [What can I write an article about?](#what-can-i-write-an-article-about) | ||
| - [How to contribute](#how-to-contribute) | ||
| - [How to contribute](#how-to-submit-a-pr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title and URL don't match here. Maybe they could be switched to [How to submit your article](#how-to-submit-your-article) or similar?
docs/docs/gatsby-style-guide.md
Outdated
| Before you begin writing, make sure to read the rest of this style guide. | ||
|
|
||
| # How to contribute | ||
| # How to submit a PR |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
docs/docs/gatsby-style-guide.md
Outdated
| find the article stub you'd like to write or edit. All stubs will be in an | ||
| index.md file. | ||
| find the article stub you'd like to write or edit. All stubs will end with the .md file ending since they are written in Markdown. | ||
| 3. Click the "Edit this file" pencil icon and make your changes to the file in |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
docs/docs/gatsby-style-guide.md
Outdated
| find the article stub you'd like to write or edit. All stubs will end with the .md file ending since they are written in Markdown. | ||
| 3. Click the "Edit this file" pencil icon and make your changes to the file in | ||
| GitHub-flavored Markdown. | ||
| 4. Scroll to the bottom of the screen and add a commit message explaining your |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing opening " around pull request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean this? "Create a new branch for this commit and start a pull request"
docs/docs/gatsby-style-guide.md
Outdated
| # How to submit a PR | ||
|
|
||
| You can create a PR with your draft article (or edits on an existing article) in | ||
| two ways: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two sections could have headings? Something like Write your article on GitHub and Write your article locally
docs/docs/gatsby-style-guide.md
Outdated
|
|
||
| Each article should explain exactly one concept, and that concept should be | ||
| apparent from the article's title. | ||
| The introduction paragraph should be a 1-2 sentence explanation of the main |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
docs/docs/gatsby-style-guide.md
Outdated
| them to a GitHub repository of your own, then push them to GitHub. Then you can | ||
| right click the image and copy its image source. | ||
| Format language keywords as code - this is done with the backtick key (located | ||
| to the left of the "1" key on a US keyboard) in GitHub-flavored markdown. For |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
docs/docs/gatsby-style-guide.md
Outdated
| them to a GitHub repository of your own, then push them to GitHub. Then you can | ||
| right click the image and copy its image source. | ||
|
|
||
| Then you'd just need to reference them in your markdown file with this syntax: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
docs/docs/gatsby-style-guide.md
Outdated
| Then you'd just need to reference them in your markdown file with this syntax: | ||
| `[your alt text](your url)` | ||
|
|
||
| Then the images should show up when you click the "preview table" tab. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
docs/docs/gatsby-style-guide.md
Outdated
|
|
||
| Also, there's a community of support from a whole team of contributors, whom you | ||
| can bounce ideas off of and ask for input on your writing. Stay active in the | ||
| contributors chat room and ask lots of questions. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@shannonbux in answer to your questions up there:
Both the List Apart and Digital Ocean styleguides are pretty long too. I don't think we should worry about shortening as long as the structure is good.
Hmm those links didn't work for me - they all go to 'Page not found' page
I don't understand this question... sorry!
This section could be more explicit I guess? Something about how it's not OK to copy and paste large chunks of existing content unless you've checked with the author? |
Need help formatting code examples within code examples ``` markdown stuff ```shell code ``` <--how do I make sure this doesn't close out the first three backticks? more markdown stuff ```
|
Deploy preview for using-contentful failed. Built with commit a0032b8 https://app.netlify.com/sites/using-contentful/deploys/5b80530982d3f15bfffd1a2e |
|
Deploy preview for image-processing failed. Built with commit e2fac23 https://app.netlify.com/sites/image-processing/deploys/5b7c5ebcfdd72a0f17a0332f |
In preparation for the docs sprint, thought this could use a lot of polish.
Questions I could use extra eyes on @jlengstorf @calcsam @m-allanson :