Fix tracedSVG fragment support in Gatsby 2.0 #6297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial tracedSVG support did not include fragments for gatsby-image in 2.0, which uses Fixed and Fluid instead of Resolutions and Sizes. Add support for these new fragments.
Collaborator
|
Deploy preview for using-drupal ready! Built with commit 79cfdda |
Collaborator
|
Deploy preview for gatsbygram ready! Built with commit 79cfdda |
m-allanson
approved these changes
Jul 5, 2018
Contributor
m-allanson
left a comment
m-allanson
left a comment
There was a problem hiding this comment.
Nice, thanks @tylermenezes!
pieh
approved these changes
Jul 6, 2018
Contributor
pieh
left a comment
pieh
left a comment
There was a problem hiding this comment.
Nice, Thanks @tylermenezes !
Contributor
|
Hiya @tylermenezes! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial tracedSVG support did not include fragments for gatsby-image in 2.0, which uses Fixed and Fluid instead of Resolutions and Sizes.
This PR simply adds the fragments for use in v2. TracedSVG seems to otherwise work fine.