Skip to content

fix: use the language loader for imports not postcss #6173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2018
Merged

fix: use the language loader for imports not postcss #6173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a87da3e
fix: use the language loader for imports not postcss
jquense Jun 26, 2018
6cc8ac5
Update snapshots
m-allanson Jun 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions packages/gatsby-plugin-less/src/__tests__/__snapshots__/gatsby-node.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exports[`gatsby-plugin-less Stage: build-html / Less options #1 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -31,7 +31,7 @@ exports[`gatsby-plugin-less Stage: build-html / Less options #1 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -68,7 +68,7 @@ exports[`gatsby-plugin-less Stage: build-html / Less options #2 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -85,7 +85,7 @@ exports[`gatsby-plugin-less Stage: build-html / Less options #2 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -121,7 +121,7 @@ exports[`gatsby-plugin-less Stage: build-html / No options 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -135,7 +135,7 @@ exports[`gatsby-plugin-less Stage: build-html / No options 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -168,7 +168,7 @@ exports[`gatsby-plugin-less Stage: build-html / PostCss plugins 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({\\"plugins\\":[\\"test1\\"]})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -182,7 +182,7 @@ exports[`gatsby-plugin-less Stage: build-html / PostCss plugins 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({\\"plugins\\":[\\"test1\\"]})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -215,7 +215,7 @@ exports[`gatsby-plugin-less Stage: build-javascript / Less options #1 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -233,7 +233,7 @@ exports[`gatsby-plugin-less Stage: build-javascript / Less options #1 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -270,7 +270,7 @@ exports[`gatsby-plugin-less Stage: build-javascript / Less options #2 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -287,7 +287,7 @@ exports[`gatsby-plugin-less Stage: build-javascript / Less options #2 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -323,7 +323,7 @@ exports[`gatsby-plugin-less Stage: build-javascript / No options 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -337,7 +337,7 @@ exports[`gatsby-plugin-less Stage: build-javascript / No options 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -370,7 +370,7 @@ exports[`gatsby-plugin-less Stage: build-javascript / PostCss plugins 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({\\"plugins\\":[\\"test1\\"]})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -384,7 +384,7 @@ exports[`gatsby-plugin-less Stage: build-javascript / PostCss plugins 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({\\"plugins\\":[\\"test1\\"]})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -417,7 +417,7 @@ exports[`gatsby-plugin-less Stage: develop / Less options #1 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -435,7 +435,7 @@ exports[`gatsby-plugin-less Stage: develop / Less options #1 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -472,7 +472,7 @@ exports[`gatsby-plugin-less Stage: develop / Less options #2 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -489,7 +489,7 @@ exports[`gatsby-plugin-less Stage: develop / Less options #2 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -525,7 +525,7 @@ exports[`gatsby-plugin-less Stage: develop / No options 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -539,7 +539,7 @@ exports[`gatsby-plugin-less Stage: develop / No options 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -572,7 +572,7 @@ exports[`gatsby-plugin-less Stage: develop / PostCss plugins 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({\\"plugins\\":[\\"test1\\"]})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -586,7 +586,7 @@ exports[`gatsby-plugin-less Stage: develop / PostCss plugins 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({\\"plugins\\":[\\"test1\\"]})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -619,7 +619,7 @@ exports[`gatsby-plugin-less Stage: develop-html / Less options #1 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -637,7 +637,7 @@ exports[`gatsby-plugin-less Stage: develop-html / Less options #1 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -674,7 +674,7 @@ exports[`gatsby-plugin-less Stage: develop-html / Less options #2 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -691,7 +691,7 @@ exports[`gatsby-plugin-less Stage: develop-html / Less options #2 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -727,7 +727,7 @@ exports[`gatsby-plugin-less Stage: develop-html / No options 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -741,7 +741,7 @@ exports[`gatsby-plugin-less Stage: develop-html / No options 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down Expand Up @@ -774,7 +774,7 @@ exports[`gatsby-plugin-less Stage: develop-html / PostCss plugins 1`] = `
"test": /\\\\\\.module\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"modules\\":true,\\"importLoaders\\":1})",
"css({\\"modules\\":true,\\"importLoaders\\":2})",
"postcss({\\"plugins\\":[\\"test1\\"]})",
Object {
"loader": "/resolved/path/less-loader",
Expand All @@ -788,7 +788,7 @@ exports[`gatsby-plugin-less Stage: develop-html / PostCss plugins 1`] = `
"test": /\\\\\\.less\\$/,
"use": Array [
"miniCssExtract",
"css({\\"importLoaders\\":1})",
"css({\\"importLoaders\\":2})",
"postcss({\\"plugins\\":[\\"test1\\"]})",
Object {
"loader": "/resolved/path/less-loader",
Expand Down
4 changes: 2 additions & 2 deletions packages/gatsby-plugin-less/src/gatsby-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ exports.onCreateWebpackConfig = (
? [loaders.null()]
: [
loaders.miniCssExtract(),
loaders.css({ importLoaders: 1 }),
loaders.css({ importLoaders: 2 }),
loaders.postcss({ plugins: postCssPlugins }),
lessLoader,
],
Expand All @@ -31,7 +31,7 @@ exports.onCreateWebpackConfig = (
test: /\.module\.less$/,
use: [
loaders.miniCssExtract(),
loaders.css({ modules: true, importLoaders: 1 }),
loaders.css({ modules: true, importLoaders: 2 }),
loaders.postcss({ plugins: postCssPlugins }),
lessLoader,
],
Expand Down
Loading