Fix hierarchy of directories to look for loaders and modules #435
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two longstanding problems. First that starters had to ship with modules/utilities that Gatsby already included and second that installing a starter with NPM 2 often has problems. I did some more research into this and realized the problem is that we don't tell Gatsby to look in `/node_modules/gatsby/node_modules` to look for modules and loaders. This means the starter also has to install them (especially with NPM 2 which doesn't put dependencies of dependencies at top-level of node_modules like NPM 3 does). By telling Webpack to look in Gatsby's node_modules directory as well we should be able to elimintate extra dependencies from starters as well as fix intermittent NPM 2 problems.
KyleAMathews
force-pushed
the
fix-resolve
branch
from
d97db36 to
b3fbea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two longstanding problems.
First that starters had to ship with modules/utilities that Gatsby
already included and second that installing a starter with NPM 2 often
has problems.
I did some more research into this and realized the problem is that we
don't tell Gatsby to look in
/node_modules/gatsby/node_modulesto lookfor modules and loaders. This means the starter also has to install them
(especially with NPM 2 which doesn't put dependencies of dependencies at
top-level of node_modules like NPM 3 does).
By telling Webpack to look in Gatsby's node_modules directory as well we
should be able to elimintate extra dependencies from starters as well as
fix intermittent NPM 2 problems.