Skip to content

fix(api-runner-node): build should stop on error #4347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2018
Merged

fix(api-runner-node): build should stop on error #4347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eb8c09
fix(api-runner-node): build should stop on error
anjawaldbauer Mar 3, 2018
195e96c
style(api-runner-node): arrow fn must return value
anjawaldbauer Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/gatsby/src/utils/api-runner-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,10 @@ module.exports = async (api, args = {}, pluginSource) =>
},
(err, results) => {
if (err) {
reporter.error(`${pluginName} returned an error`, err)
Copy link
Contributor

@KyleAMathews KyleAMathews Mar 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since panicOnBuild doesn't exist, you can do the same thing by adding a conditional if (process.env.NODE_ENV === "production") { /* panic */ } else { /* error */ }

if (process.env.NODE_ENV === `production`) {
return reporter.panic(`${pluginName} returned an error`, err)
}
return reporter.error(`${pluginName} returned an error`, err)
}
// Remove runner instance
apisRunning = apisRunning.filter(runner => runner !== apiRunInstance)
Expand All @@ -181,7 +184,7 @@ module.exports = async (api, args = {}, pluginSource) =>
}

// Check if any of our waiters are done.
waitingForCasacadeToFinish = waitingForCasacadeToFinish.filter(
return waitingForCasacadeToFinish = waitingForCasacadeToFinish.filter(
instance => {
// If none of its trace IDs are running, it's done.
if (!_.some(apisRunning, a => a.traceId === instance.traceId)) {
Expand Down