Add documentation for createRemoteFileNode #4330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I realize the indentation is a bit messed up, I'll fix that as well in the next commit. |
Collaborator
|
Deploy preview for gatsbygram ready! Built with commit e63a358 |
Contributor
|
Looks good from a quick pass over! Lemme know when you've fixed things to your satisfaction. |
Contributor
Author
|
@KyleAMathews I've patched up whatever I could think of from whatever I know; do make suggestions if any, else I guess it can be merged. |
ghost
assigned
Contributor
|
Thanks! Made a few more tweaks. Glad to have this documented! |
Contributor
Author
|
Glad to contribute, also it looks great now! Thanks @KyleAMathews |
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
* Add rough docs for createRemoteFileNode * Minor patches * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4302
I've added rough documentation for
createRemoteFileNode. As you can see it's still needs a lot of improvement. Any guidance would be appreciated.What's to be added/improved:
createRemoteFileNodedoes. For instance thestoreandcachethat's passed in.node.localFile___NODE = fileNode.iddoes@m-allanson @KyleAMathews @pieh