Skip to content

Don't exit on errors as during development, empty/incomplete page components are common fixes #4027 #4040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2018
Merged

Don't exit on errors as during development, empty/incomplete page components are common fixes #4027 #4040

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca8e360
Don't exit on errors as during development, empty/incomplete page com…
KyleAMathews Feb 14, 2018
ebb8068
Fix other points of death
KyleAMathews Feb 14, 2018
d74036f
Ok, do die here
KyleAMathews Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions packages/gatsby/src/redux/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,15 +232,10 @@ actions.createPage = (page: PageInput, plugin?: Plugin, traceId?: string) => {
`You have an empty file in the "src/pages" directory at "${relativePath}". Please remove it or make it a valid component`
)
console.log(``)
process.exit(1)
// TODO actually do die during builds.
// process.exit(1)
}

console.log(``)
console.log(``)
console.log(
`The page component at "${relativePath}" didn't pass validation`
)

if (!includesDefaultExport) {
console.log(``)
console.log(
Expand All @@ -249,7 +244,8 @@ actions.createPage = (page: PageInput, plugin?: Plugin, traceId?: string) => {
console.log(``)
}

process.exit(1)
// TODO actually do die during builds.
// process.exit(1)
}
}

Expand Down