fix(gatsby): Adapter header rules #38644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: adapters
pieh
reviewed
Oct 19, 2023
packages/gatsby/src/utils/adapter/__tests__/__snapshots__/manager.ts.snap
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Tests were passing, but a new test is failing after merging in master https://app.circleci.com/pipelines/github/gatsbyjs/gatsby/91772/workflows/deb2a349-7db6-4970-965d-01578ec83ea5/jobs/1111499/tests |
Contributor
Author
Ran again and it passed 🎉 |
mraerino
approved these changes
Oct 23, 2023
mraerino
left a comment
mraerino
left a comment
There was a problem hiding this comment.
looks good to me!
did you want to add an integration test with a dummy adapter maybe?
pieh
approved these changes
Oct 23, 2023
Contributor
Author
As discussed in the sync, I'll update the E2E tests in the follow-up PR with the adapter changes. |
pieh
pushed a commit
that referenced
this pull request
Oct 24, 2023
* simplified header rules * lint * lint * update test/snapshot * update snapshot * add snapshot for headerRoutes * export type (cherry picked from commit dc21604)
This was referenced Dec 22, 2023
This was referenced Dec 29, 2023
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjustment to reduce the header file size.
Based off of work done by #38561. The primary difference is the equality checks for filtering the headers.
includesdoesn't work since JS checks for reference equality.Documentation
Tests
Unit tests
Related Issues
Fixes https://linear.app/netlify/issue/FRA-17/reduce-headers-file-size