Skip to content

fix(gatsby): support multiple instances of same variable in gatsbyImage placeholderUrl - #38626

Merged
pieh merged 2 commits into
gatsbyjs:masterfrom
cunhacf:master
Oct 20, 2023
Merged

fix(gatsby): support multiple instances of same variable in gatsbyImage placeholderUrl#38626
pieh merged 2 commits into
gatsbyjs:masterfrom
cunhacf:master

Conversation

@cunhacf

@cunhacf cunhacf commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

Description

Fixes a bug where multiple instances of variables in gatsbyImage's placeholderUrl are only replaced once.

Tests

Tested locally.

Related Issues

Fixes #38604

@gatsbot gatsbot Bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 10, 2023
@pieh pieh added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 20, 2023
pieh
pieh approved these changes Oct 20, 2023
View reviewed changes

@pieh pieh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, thanks!

@pieh
pieh merged commit b177db9 into gatsbyjs:master Oct 20, 2023
@gatsbybot gatsbybot mentioned this pull request Oct 20, 2023
Merged
pieh pushed a commit that referenced this pull request Oct 20, 2023
@cunhacf @pieh
fix(gatsby): support multiple instances of same variable in gatsbyIma…
a473264 
…ge placeholderUrl (#38626)

(cherry picked from commit b177db9)
pieh pushed a commit that referenced this pull request Oct 20, 2023
@gatsbybot @cunhacf
fix(gatsby): support multiple instances of same variable in gatsbyIma…
02e925a 
…ge placeholderUrl (#38626) (#38647)

(cherry picked from commit b177db9)

Co-authored-by: Carlos Fernandes Cunha <cunhacf@users.noreply.github.com>
@pieh

pieh commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

gatsby-plugin-utils@4.12.2 was released with this fix

This was referenced Nov 10, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 22, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 29, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 6, 2024
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieh pieh pieh approved these changes

Assignees

No one assigned

Labels

topic: media Related to gatsby-plugin-image, or general image/media processing topics

Projects

V5 Release hotfixes
Status: Published

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

placeholderUrl variables only get replaced once

2 participants

@cunhacf @pieh