chore(docs): clarify react upgrade with --legacy-peer-deps #38359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
This was referenced Sep 23, 2023
This was referenced Oct 15, 2023
This was referenced Oct 22, 2023
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarify the upgrade react step when migrating from v4 to v5. The previous step for upgrading Gatsby first has similar documentation.
If I follow the guide on node 18 / npm 9 and run the upgrade react command (
npm install react@latest react-dom@latest) before resolving all the other dependencies I get errors like the image below. It appears until the dependency resolution is complete by later steps--legacy-peer-depsis expected.Running with
--legacy-peer-depsresults in success.Documentation
Tests
Related Issues