Skip to content

[v2] Topics/peer dependencies #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 9, 2018
Merged

[v2] Topics/peer dependencies #3671

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d4a96e2
move react and react-dom to peerDependencies
flipactual Jan 23, 2018
07f4b37
document installing react and react-dom
flipactual Jan 23, 2018
4430fa9
move react-jss to peerDependencies
flipactual Jan 23, 2018
af3ff4e
move lodash to peerDependencies
flipactual Jan 23, 2018
30e0038
remove instruction to install react/react-dom globally
flipactual Jan 23, 2018
0c85714
move react and react-dom to peerDependencies
flipactual Jan 24, 2018
1cde92d
move preact and preact-compat to peerDependencies
flipactual Jan 24, 2018
fb35b7e
move react-typography and typography to peerDependencies
flipactual Jan 24, 2018
ec5411f
Merge branch 'v2' into topics/peer-dependencies
KyleAMathews Feb 9, 2018
05cf9d9
Up major version for affected plugins
KyleAMathews Feb 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/gatsby-cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ package installed locally.

## Install

`npm install --global gatsby-cli`
`npm install --global gatsby-cli react react-dom`
Copy link
Contributor

@pieh pieh Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's right. We don't want to install those globally.

Copy link
Contributor Author

@flipactual flipactual Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

womp, thank you

Copy link
Contributor

@pieh pieh Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not expert on dependencies but these propably should be added to starters as dependencies but there are so many of those starters and many of them are unofficial so making react and react-dom peer dependencies will break them I think

Copy link
Contributor Author

@flipactual flipactual Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just arrived at the same conclusion 👍

This is coming with a major version bump – I'd be surprised if this is the only thing that breaks compatibility with existing starters, but I don't know

Copy link
Contributor

@KyleAMathews KyleAMathews Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah — we'll upgrade the official starters and perhaps a few others. There'll be an upgrade guide for sites that starters will need to go through. It won't break anything though as a starter with a gatsby@1 dependency will keep working as normal.


## How to use

Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby-plugin-jss/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Provide drop-in support for using the css-in-js library

## Install

`npm install --save gatsby-plugin-jss`
`npm install --save gatsby-plugin-jss react-jss`

## How to use

Expand Down
4 changes: 3 additions & 1 deletion packages/gatsby-plugin-jss/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
"author": "Vladimir Guguiev <[email protected]>",
"license": "MIT",
"dependencies": {
"babel-runtime": "^6.26.0",
"babel-runtime": "^6.26.0"
},
"peerDependencies": {
"react-jss": "^7.0.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby-plugin-lodash/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Adds the Lodash webpack & Babel plugins for easy modular, small Lodash builds.

## Install

`npm install --save gatsby-plugin-lodash`
`npm install --save gatsby-plugin-lodash lodash`

## How to use

Expand Down
4 changes: 3 additions & 1 deletion packages/gatsby-plugin-lodash/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@
"dependencies": {
"babel-plugin-lodash": "^3.2.11",
"babel-runtime": "^6.26.0",
"lodash": "^4.17.4",
"lodash-webpack-plugin": "^0.11.4"
},
"peerDependencies": {
"lodash": "^4.17.4"
},
"devDependencies": {
"babel-cli": "^6.26.0",
"cross-env": "^5.0.5"
Expand Down
6 changes: 4 additions & 2 deletions packages/gatsby/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,7 @@
"postcss-loader": "^2.0.6",
"postcss-reporter": "^5.0.0",
"raw-loader": "^0.5.1",
"react": "^16.2.0",
"react-dev-utils": "^4.2.1",
"react-dom": "^16.2.0",
"react-error-overlay": "^3.0.0",
"react-hot-loader": "^3.0.0-beta.6",
"react-router": "^4.1.1",
Expand Down Expand Up @@ -121,6 +119,10 @@
"webpack-stats-plugin": "^0.1.5",
"yaml-loader": "^0.5.0"
},
"peerDependencies": {
"react": "^16.2.0",
"react-dom": "^16.2.0"
},
"devDependencies": {
"babel-cli": "^6.26.0",
"chokidar": "^2.0.0",
Expand Down