Skip to content

[www] Search shortcut #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2018
Merged

[www] Search shortcut #3654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66e6144
Add keyboard shortcut for focussing the search input
m-allanson Jan 22, 2018
e1d0a2e
Blur input on result selection
m-allanson Jan 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion www/src/components/search-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ css.insert(`
font-weight: normal !important;
padding: ${rhythm(0.25)} ${rhythm(0.5)} !important;
}

.algolia-autocomplete .algolia-docsearch-suggestion--subcategory-column:before {
background: ${presets.veryLightPurple} !important;
}
Expand Down Expand Up @@ -227,6 +227,8 @@ class SearchForm extends Component {
constructor() {
super()
this.state = { enabled: true }
this.autocompleteSelected = this.autocompleteSelected.bind(this)
this.focusSearchInput = this.focusSearchInput.bind(this)
}

/**
Expand All @@ -241,9 +243,17 @@ class SearchForm extends Component {
// eslint-disable-next-line no-undef
const a = document.createElement(`a`)
a.href = e._args[0].url
this.searchInput.blur()
navigateTo(`${a.pathname}${a.hash}`)
}

focusSearchInput(e) {
if (e.key !== `s`) return
if (document.activeElement === this.searchInput) return // eslint-disable-line no-undef
e.preventDefault()
this.searchInput.focus()
}

componentDidMount() {
if (
typeof window === `undefined` || // eslint-disable-line no-undef
Expand All @@ -254,6 +264,9 @@ class SearchForm extends Component {
return
}

// eslint-disable-next-line no-undef
window.addEventListener(`keydown`, this.focusSearchInput)

// eslint-disable-next-line no-undef
window.addEventListener(
`autocomplete:selected`,
Expand All @@ -270,6 +283,11 @@ class SearchForm extends Component {
})
}

componentWillUnmount() {
// eslint-disable-next-line no-undef
window.removeEventListener(`keydown`, this.focusSearchInput)
}

render() {
const { enabled } = this.state
const { styles } = this.props.styles
Expand Down Expand Up @@ -320,6 +338,8 @@ class SearchForm extends Component {
type="search"
placeholder="Search docs"
aria-label="Search docs"
title="Hit 's' to search docs"
ref={(input) => { this.searchInput = input }}
/>
</form>
) : null
Expand Down