feat(gatsby): Add option to emit TS types during build #36405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
topic: TypeScript
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
LekoArts
commented
Aug 17, 2022
LekoArts
commented
Aug 17, 2022
| const waitWorkerPoolEnd = Promise.all(workerPool.end()) | ||
|
|
||
| // create scope so we don't leak state object | ||
| { |
Contributor
Author
There was a problem hiding this comment.
The position of this is quite arbitrary (at the very end of the build). Any reason to not keep it there?
LekoArts
commented
Aug 17, 2022
| if (state.config.graphqlTypegen) { | ||
| telemetry.trackFeatureIsUsed(`GraphQLTypegen`) | ||
| writeGraphQLConfig(program) | ||
| // This is only run during `gatsby develop` |
Contributor
Author
There was a problem hiding this comment.
This is correcting the implementation to actually do what the comment said (this file is not needed during gatsby build)
imjoshin
previously approved these changes
Aug 17, 2022
Contributor
imjoshin
left a comment
imjoshin
left a comment
There was a problem hiding this comment.
Will defer merge until name is decided. Code looks good though!
pieh
approved these changes
Aug 18, 2022
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced May 15, 2024
This was referenced May 15, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The request to also have
src/gatsby-types.d.tsduringgatsby buildhas come up more and more in #35420, so this is adding an option to generate this file duringgatsby build.I'm totally open to a better name than
gatsbyBuild!Documentation
Docs were changed