Skip to content

Conversation

@TylerBarnes
Copy link
Contributor

With Gatsby's new Image CDN feature we added a new GraphQL field gatsbyImage which is used in place of gatsbyImageData. This PR adds a check for that in the getImage helper.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 27, 2022
@TylerBarnes TylerBarnes added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 27, 2022
wardpeet
wardpeet previously approved these changes Apr 28, 2022
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test?

veryspry
veryspry previously approved these changes Apr 29, 2022
@TylerBarnes TylerBarnes dismissed stale reviews from veryspry and wardpeet via f5d9aa2 April 29, 2022 16:55
Copy link
Contributor

@veryspry veryspry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

@TylerBarnes TylerBarnes merged commit abc6dca into master May 3, 2022
@TylerBarnes TylerBarnes deleted the fix/get-image-for-image-cdn branch May 3, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: media Related to gatsby-plugin-image, or general image/media processing topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants