Skip to content

feat(gatsby-plugin-gatsby-cloud): Add disablePreviewUI option #32907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielSLew merged 2 commits into from
Aug 26, 2021
Merged

feat(gatsby-plugin-gatsby-cloud): Add disablePreviewUI option #32907

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0593eea
added pluginOptions from wrappRootElement
Aug 25, 2021
aa96c3f
updated access to the pluginOptions property and added the disabledPr…
Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/gatsby-plugin-gatsby-cloud/src/gatsby-browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,11 @@ const ShadowPortal = ({ children, identifier }) => {
)
}

export const wrapRootElement = ({ element }) => {
if (process.env.GATSBY_PREVIEW_INDICATOR_ENABLED === `true`) {
export const wrapRootElement = ({ element }, pluginOptions) => {
if (
process.env.GATSBY_PREVIEW_INDICATOR_ENABLED === `true` &&
!pluginOptions.disablePreviewUI
Copy link
Copy Markdown
Contributor

@DanielSLew DanielSLew Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!pluginOptions.disablePreviewUI
!pluginOptions?.disablePreviewUI

I can't remember if they have no options pluginOptions will be undefined or it will be an empty object. So let's just guard against it in case it is undefined

) {
return (
<>
{element}
Expand Down