Skip to content

feat(gatsby-source-wordpress): allow path to js file for beforeChangeNode option#32901

Merged
TylerBarnes merged 4 commits into
masterfrom
feat/wp-allow-fn-path-for-beforechangenode-option
Aug 26, 2021
Merged

feat(gatsby-source-wordpress): allow path to js file for beforeChangeNode option#32901
TylerBarnes merged 4 commits into
masterfrom
feat/wp-allow-fn-path-for-beforechangenode-option

Conversation

@TylerBarnes
Copy link
Copy Markdown
Contributor

In Gatsby v4 functions in plugin options wont work anymore. This change alters the beforeChangeNode plugin type option to allow entering a path to a js file instead.

@gatsbot gatsbot Bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 25, 2021
beforeChangeNodePath
)
? beforeChangeNodePath
: require.resolve(
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wardpeet you mentioned gatsby-fs. Is that available now or will this need to be updated in the future?

Comment thread packages/gatsby-source-wordpress/docs/plugin-options.md
@TylerBarnes TylerBarnes requested a review from DanielSLew August 25, 2021 18:43
@TylerBarnes TylerBarnes merged commit ac7bd4e into master Aug 26, 2021
@TylerBarnes TylerBarnes deleted the feat/wp-allow-fn-path-for-beforechangenode-option branch August 26, 2021 16:04
wardpeet pushed a commit that referenced this pull request Aug 27, 2021
…Node option (#32901)

* Allow path to js file for beforeChangeNode option

* ensure Joi doesn't fail the build for inline beforeChangeNode fn's

* Create gatsby-version.ts

* Panic on Gatsby v4+ if beforeChangeNode is a function.
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 30, 2021
raffishquartan pushed a commit to raffishquartan/gatsby that referenced this pull request Apr 28, 2026
…Node option (gatsbyjs#32901)

* Allow path to js file for beforeChangeNode option

* ensure Joi doesn't fail the build for inline beforeChangeNode fn's

* Create gatsby-version.ts

* Panic on Gatsby v4+ if beforeChangeNode is a function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants