fix(gatsby-remark-image-contentful): show useful error message for files that can not be rendered as image #32530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
2 tasks
Contributor
|
Tested this locally in my reduced tescase from #32511 and works great! |
Contributor
Author
|
@bartveneman awesome, thanks for testing. |
wardpeet
changed the title
wardpeet
reviewed
Aug 3, 2021
| } | ||
| }), | ||
| } | ||
| return { metadata: mockedSharpMetadata } |
Contributor
There was a problem hiding this comment.
Suggested change
| return { metadata: mockedSharpMetadata } | |
| return { metadata: jest.fn() } |
Contributor
Author
There was a problem hiding this comment.
I changed it closer to how gatsby-plugin-sharp mocks sharp. Please have a look
Comment on lines
25
to
39
| const mockSharpSuccess = () => { | ||
| mockedSharpMetadata = jest.fn(() => { | ||
| return { | ||
| width: 200, | ||
| height: 200, | ||
| density: 75, | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| const mockSharpFailure = () => { | ||
| mockedSharpMetadata = jest.fn(() => | ||
| Promise.reject(new Error(`invalid image`)) | ||
| ) | ||
| } |
Contributor
There was a problem hiding this comment.
This is the proper way to mock :)
Suggested change
| const mockSharpSuccess = () => { | |
| mockedSharpMetadata = jest.fn(() => { | |
| return { | |
| width: 200, | |
| height: 200, | |
| density: 75, | |
| } | |
| }) | |
| } | |
| const mockSharpFailure = () => { | |
| mockedSharpMetadata = jest.fn(() => | |
| Promise.reject(new Error(`invalid image`)) | |
| ) | |
| } | |
| const sharp = require('sharp'); | |
| const mockSharpSuccess = () => { | |
| sharp.metadata.mockResolvedValueOnce({ | |
| width: 200, | |
| height: 200, | |
| density: 75, | |
| }) | |
| } | |
| const mockSharpFailure = () => { | |
| sharp.metadata.mockRejectedValue(new Error(`invalid image`) | |
| } |
LekoArts
added
topic: plugins
wardpeet
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32511