Skip to content

fix(gatsby): fix proxy creation on read-only properties (#31346) #31364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladar merged 1 commit into from
May 11, 2021
Merged

fix(gatsby): fix proxy creation on read-only properties (#31346) #31364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/gatsby/cache-dir/ssr-builtin-trackers/__tests__/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
const fs = require(`../fs`)

describe(`tracking fs`, () => {
it(`doesn't crash on accessing fs.constants`, () => {
expect(() => fs.constants).not.toThrow()
})
})
12 changes: 12 additions & 0 deletions packages/gatsby/cache-dir/ssr-builtin-trackers/tracking-unsafe-module-wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,18 @@ function createProxyHandler(prefix, options) {
return value
}

const fieldDescriptor = Object.getOwnPropertyDescriptor(target, key)
if (fieldDescriptor && !fieldDescriptor.writable) {
// this is to prevent errors like:
// ```
// TypeError: 'get' on proxy: property 'constants' is a read - only and
// non - configurable data property on the proxy target but the proxy
// did not return its actual value
// (expected '[object Object]' but got '[object Object]')
// ```
return value
}

if (typeof value === `function`) {
return function wrapper(...args) {
const myErrorHolder = {
Expand Down