fix(gatsby-source-wordpress): invalidate less queries during previews #30770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
added
topic: source-wordpress
DanielSLew
approved these changes
Apr 9, 2021
Contributor
DanielSLew
left a comment
DanielSLew
left a comment
There was a problem hiding this comment.
Looks good to me! There's one failing test ci/circleci: e2e_tests_pnp, it doesn't look like this is related though.
Contributor
Author
|
Thanks @DanielSLew ! |
moonmeister
added a commit
that referenced
this pull request
Apr 14, 2021
* master: (183 commits) chore(gatsby-plugin-image): Remove version note (#30758) docs: retire 'How to Create Pages' stub and Recipes landing page (#30842) chore(docs): Fix typo (#30858) docs: fix invalid mailto links in 3.3 release notes (#30862) docs: release notes for 3.3 (#30837) fix(gatsby-source-wordpress): invalidate less queries during previews (#30770) fix(gatsby-starter-wordpress-blog): Fix altText (#30832) feat(contentful): warn users when using restricted content type names (#30715) Refactor: using-contentful to use gatsby-plugin-image exclusively (#30717) chore(gatsby-plugin-styled-components): Remove breaking changes section (#30806) fix(gatsby): webpack warnings are no longer in object format by default (#30801) fix(gatsby): Decode base path in runtime (#30682) fix(gatsby): "Cannot find module 'babel-preset-gatsby'" error (#30813) handle plugin parentDir resolution in resolvePlugin() (#30812) Port using-gatsby-image site to image plugin (#28489) fix(gatsby-source-contentful): De-dupe type names (#30834) feat(gatsby): Add aggregation resolvers (#30789) fix(gatsby-core-utils): fetch-remote-file download failure when missing content-length header (#30810) fix(renovate): add breaking minor updates to major updates list (#30676) chore(docs): Update migration guide for plugins that support both v2 & v3 (#30825) ...
vladar
pushed a commit
that referenced
this pull request
Apr 19, 2021
…#30770) (#30942) (cherry picked from commit bb25e5b) Co-authored-by: Tyler Barnes <[email protected]>
Contributor
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Preview, revisions of a node type can have data that updates unnecessarily
This PR fixes that. The result being that less queries are invalidated in Gatsby. For example if you have a query where you're getting the latest published post using the date field, that data should be static but each preview updates the date field on the node being previewed (because the revision has a new date). So if we prevent the fields in this PR from changing, this will be less problematic.
This makes preview for GatsbyJS.com significantly faster