chore(gatsby): Remove hasNodeChanged #29208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: internal
topic: plugins
gillkyle
approved these changes
Feb 8, 2021
Contributor
gillkyle
left a comment
gillkyle
left a comment
There was a problem hiding this comment.
Looks straightforward enough!
It looks like this PR removes existing places where hasNodeChanged is destructured in plugins, and removes it's references in docs.
My only question would be, can the actual declaration of hasNodeChanged be removed as well? https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/src/redux/nodes.ts#L101-L111
Contributor
Author
|
@gillkyle The function is used internally here :) |
LekoArts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the deprecated
hasNodeChangedAPI from the public API surface.Documentation
Related Issues
[ch23649]