Skip to content

Add gatsby-compression-plugin. #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add gatsby-compression-plugin. #2913

wants to merge 4 commits into from

Conversation

@hbowden
Copy link

@hbowden hbowden commented Nov 14, 2017 •
edited
Loading

A plugin for gzipping assets.

@gatsbybot
Copy link
Collaborator

gatsbybot commented Nov 14, 2017

Deploy preview ready!

Built with commit 75aea6f

https://deploy-preview-2913--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Nov 14, 2017

Deploy preview ready!

Built with commit 75aea6f

https://deploy-preview-2913--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Nov 14, 2017 •
edited
Loading

Deploy preview ready!

Built with commit 6d6ca92

https://deploy-preview-2913--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Nov 14, 2017

Nice! Should this also work on non-webpack handled assets e.g. images generated by gatsby-plugin-sharp? Perhaps go through files and see which ones don't have gz and gzip them too?

dustinhorton
dustinhorton reviewed Nov 14, 2017
View reviewed changes
packages/gatsby-compression-plugin/README.md

# Nginx

If your using nginx you can use `gzip_static on;` to serve your gzipped assets, here's a full example.
Copy link
Contributor

@dustinhorton dustinhorton Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbowden you’re

Also, this is rad, nice work.

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Nov 14, 2017

Deploy preview failed.

Built with commit a2f1624

https://app.netlify.com/sites/using-glamor/deploys/5a0b0379a6188f349996adcb

@hbowden
Copy link
Author

hbowden commented Nov 16, 2017

Thanks for the suggestions, I'll update the pull request. About the failed deploy preview, it seemed to be working before the merge, I'll try to figure out whats broken. Is there a command to run the deploy preview locally for testing? Also I'll look into gzipping the assets created by gatsby-plugin-sharp and dynamic imports which are not currently supported webpack/compression-webpack-plugin#79.

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Nov 20, 2017

The deploy preview stuff is in bad shape and is being replaced soon so just ignore it for now :-(

@ghost ghost assigned KyleAMathews Dec 14, 2017
@ghost ghost added the review label Dec 14, 2017
@KyleAMathews
Copy link
Contributor

KyleAMathews commented Dec 14, 2017

@hbowden would love to see this finished up!

@ghost ghost removed the review label Feb 6, 2018
@KyleAMathews
Copy link
Contributor

KyleAMathews commented Feb 6, 2018

Please refile a new PR if you get to it!

@tejzpr tejzpr mentioned this pull request Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dustinhorton dustinhorton dustinhorton left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@KyleAMathews KyleAMathews

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hbowden @gatsbybot @KyleAMathews @dustinhorton @sebastienfi