chore(gatsby-plugin-image): Unflag remote images #29032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
commented
Jan 14, 2021
| if (isRemoteURL(src)) { | ||
| let createRemoteFileNode | ||
| try { | ||
| ;({ createRemoteFileNode } = require(`gatsby-source-filesystem`)) |
Contributor
Author
There was a problem hiding this comment.
Yeah, I know, @laurieontech. This is just easier to read.
Contributor
There was a problem hiding this comment.
Haha I agree, don’t worry
Contributor
Author
There was a problem hiding this comment.
I mean, I'm grateful that I now know how to do it!
laurieontech
approved these changes
Jan 14, 2021
ascorbic
added
bot: merge on green
This was referenced Jan 19, 2021
Open
This was referenced Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote images are no more experimental than the rest of the image plugin now, so I think it's fine to unflag them.