[query-runner] Prevent empty error message for GraphQL errors #2891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Deploy preview ready! Built with commit 854a961 |
Collaborator
|
Deploy preview ready! Built with commit 854a961 |
Contributor
|
Thanks! Yeah, this is a good idea — if we don't know how to neatly display an error — just spew out an unfiltered version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A raw solution to prevent GraphQL queries from having any error messages. Better an ugly error message than no error message, isn't it?
Probably a more suitable solution would be to modify this function so that it accepts more input formatting. I don't have time to do that this month, I hope someone else will have time to focus on it.