fix(gatsby): Only set auto optin flags if not in config #28627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
force-pushed
the
fix/flags/dont-treat-explicit-opt-in-as-auto-opt-in
branch
from
be7525d to
471534e
Compare
…opted in flags list
pieh
force-pushed
the
fix/flags/dont-treat-explicit-opt-in-as-auto-opt-in
branch
from
471534e to
685f8a2
Compare
pieh
commented
Dec 15, 2020
Comment on lines
-73
to
+75
| if (configFlags[flag.name] !== false && fitness === `OPT_IN`) { | ||
| // if user didn't explicitly set a flag (either true or false) | ||
| // and it qualifies for auto opt-in - add it to optedInFlags | ||
| if (typeof configFlags[flag.name] === `undefined` && fitness === `OPT_IN`) { |
pieh
commented
Dec 15, 2020
Comment on lines
-146
to
+148
| and your site was automatically choosen as one of them. With your help, we'll then release them to everyone in the next minor release. | ||
| and your site was automatically chosen as one of them. With your help, we'll then release them to everyone in the next minor release. |
Contributor
There was a problem hiding this comment.
You mean randomly spotted typo 
Contributor
Author
There was a problem hiding this comment.
hahaha, oh the irony xD
pieh
force-pushed
the
fix/flags/dont-treat-explicit-opt-in-as-auto-opt-in
branch
from
d883828 to
f1ed5dc
Compare
pieh
force-pushed
the
fix/flags/dont-treat-explicit-opt-in-as-auto-opt-in
branch
from
f1ed5dc to
e79cb21
Compare
sidharthachatterjee
changed the title
sidharthachatterjee
approved these changes
Dec 15, 2020
Contributor
sidharthachatterjee
left a comment
sidharthachatterjee
left a comment
There was a problem hiding this comment.
Nice work! Thanks 🥧
sidharthachatterjee
deleted the
fix/flags/dont-treat-explicit-opt-in-as-auto-opt-in
branch
LekoArts
pushed a commit
that referenced
this pull request
Dec 15, 2020
(cherry picked from commit b81e6bd)
LekoArts
added a commit
that referenced
this pull request
Dec 15, 2020
) (cherry picked from commit b81e6bd) Co-authored-by: Michal Piechowiak <[email protected]>
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This doesn't change behaviour - this is only to address message that is displayed.
Currently when user explicitly opt-in in config AND site get's picked for auto opt-in we do display message that site was auto opted-in - this is confusing because user already did opt-in manually and we should prefer that over auto opt-in message.