Skip to content

Conversation

@ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Dec 3, 2020

Revert #28459, as it was breaking gatsby-source-graphql. Instead add the --ignore-engines flag to the dev cli so that e2e tests can at least run

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 3, 2020
@ascorbic ascorbic added topic: dev tooling and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 3, 2020
vladar
vladar previously approved these changes Dec 3, 2020
@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 3, 2020
@ascorbic ascorbic merged commit 4add7d2 into master Dec 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/handle-engines branch December 3, 2020 16:05
pieh pushed a commit that referenced this pull request Dec 4, 2020
* fix: Back out resolutions, and add ignore-engines to dev cli

* Use dev-cli@next

(cherry picked from commit 4add7d2)
pieh added a commit that referenced this pull request Dec 4, 2020
* fix(gatsby-source-graphql): Pin resolution of extract-files (#28459)

(cherry picked from commit 4ef4bf5)

* fix: Back out resolutions, and add ignore-engines to dev cli (#28464)

* fix: Back out resolutions, and add ignore-engines to dev cli

* Use dev-cli@next

(cherry picked from commit 4add7d2)

Co-authored-by: Matt Kane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: merge on green Gatsbot will merge these PRs automatically when all tests passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants