Skip to content

fix(gatsby-source-filesystem): Use new FileType methods to read file extension - #28156

Merged
pvdz merged 1 commit into
masterfrom
filetype
Nov 18, 2020
Merged

fix(gatsby-source-filesystem): Use new FileType methods to read file extension#28156
pvdz merged 1 commit into
masterfrom
filetype

Conversation

@pvdz

@pvdz pvdz commented Nov 18, 2020

Copy link
Copy Markdown
Contributor

This is a copy of #27559 because that branch got deleted. Copying desc verbatim;

Description

Uses fromFile(), fromBuffer() methods to infer filetype/extension from the file/buffer, if not specified.

This fixes an issue where createRemoteFileNode may fail on URLs without an extension in the path.

Documentation

  • N/A

Related Issues

@gatsbot gatsbot Bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 18, 2020
@pvdz pvdz mentioned this pull request Nov 18, 2020
Closed
@pvdz pvdz added topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 18, 2020
@pvdz
pvdz merged commit 616e9e3 into master Nov 18, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the filetype branch November 18, 2020 14:22
vladar pushed a commit that referenced this pull request Nov 19, 2020
@pvdz @vladar
fix(gatsby-source-filesystem): Use new FileType methods to read file …
3f3e16f 
…extension (#28156)

(cherry picked from commit 616e9e3)
@vladar vladar mentioned this pull request Nov 19, 2020
Merged
vladar added a commit that referenced this pull request Nov 19, 2020
@vladar @pvdz
fix(gatsby-source-filesystem): Use new FileType methods to read file …
00870bb 
…extension (#28156) (#28178)

(cherry picked from commit 616e9e3)

Co-authored-by: Peter van der Zee <209817+pvdz@users.noreply.github.com>
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
fix(gatsby-source-filesystem): Use new FileType methods to read file …
c0b82d3 
…extension (gatsbyjs#28156)
@kaocher82 kaocher82 mentioned this pull request Jul 22, 2022
Open
This was referenced Jul 22, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Jul 22, 2022
Open
This was referenced Jul 22, 2022
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request Jul 23, 2022
Open
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
@pvdz
fix(gatsby-source-filesystem): Use new FileType methods to read file …
0267709 
…extension (gatsbyjs#28156)
raffishquartan pushed a commit to raffishquartan/gatsby that referenced this pull request Apr 28, 2026
@pvdz
fix(gatsby-source-filesystem): Use new FileType methods to read file …
5bae439 
…extension (gatsbyjs#28156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

createRemoteFileNode crashes when url doesn't have an extension

2 participants

@pvdz @vladar