chore(gatsby-cli): bundle dependencies #27058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Contributor
laurieontech
left a comment
laurieontech
left a comment
There was a problem hiding this comment.
One comment for future proofing, this looks reasonable to me but admittedly should get a second set of eyes.
sidharthachatterjee
added
topic: cli
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-recipes
branch
from
4bff535 to
df712b4
Compare
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-cli
branch
from
989cebd to
201268d
Compare
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-cli
branch
from
201268d to
aec6f26
Compare
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-recipes
branch
2 times, most recently
from
799f2f9 to
dfe1502
Compare
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-cli
branch
from
aec6f26 to
754e428
Compare
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-recipes
branch
from
dfe1502 to
778e214
Compare
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-cli
branch
from
754e428 to
c3e0d74
Compare
wardpeet
reviewed
Oct 16, 2020
Comment on lines
1
to
7
| { | ||
| "presets": [["babel-preset-gatsby-package"]] | ||
| "presets": [ | ||
| [ | ||
| "@babel/env", | ||
| { | ||
| "modules": false, | ||
| "shippedProposals": true, | ||
| "targets": { "node": "10.13.0" } | ||
| } | ||
| ], | ||
| "@babel/preset-react" | ||
| ], | ||
| "plugins": ["@babel/plugin-transform-runtime"], | ||
| "overrides": [ | ||
| { | ||
| "test": ["**/*.ts", "**/*.tsx"], | ||
| "plugins": [["@babel/plugin-transform-typescript", { "isTSX": true }]] | ||
| } | ||
| ] | ||
| } |
Contributor
There was a problem hiding this comment.
could we move this inline into rollup config? So we use non-rollup-babel like all other packages?
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-recipes
branch
from
33729b8 to
95edecb
Compare
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-cli
branch
from
c3e0d74 to
15f0f14
Compare
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-recipes
branch
from
95edecb to
0d79ce8
Compare
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-cli
branch
2 times, most recently
from
b45b9e6 to
f5e1b29
Compare
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-recipes
branch
from
0d79ce8 to
3c2effc
Compare
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-cli
branch
from
28ab48e to
e64a9cb
Compare
pieh
changed the base branch from
chore/bundle-cli-and-recipes/gatsby-recipes
to
master
pieh
force-pushed
the
chore/bundle-cli-and-recipes/gatsby-cli
branch
from
e64a9cb to
af4bcf4
Compare
wardpeet
approved these changes
Oct 26, 2020
delete-merged-branch
bot
deleted the
chore/bundle-cli-and-recipes/gatsby-cli
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bundles quite a bit of dependencies which cause problems for users (react, ink) when there are multiple version of those installed in node_modules hierarchy is not quite right
This is part of PR series:
feat(gatsby-dev-cli): install deps if there are no gatsby deps but --forceInstall was usedtest(integration/gatsby-cli): use sandboxed directory to "globally" install gatsby-clichore(gatsby-recipes): bundle dependencieschore(gatsby-cli): bundle dependencies(THIS PR)[ch17886]